replace github.com/go-resty/resty with gopkg.in/resty.v1

[dmitris]

@johanbrandhorst - as discussed on Slack, did not update generated files

[johanbrandhorst]

Does this still work? I think since our generated files use the other import we still need to include both. I'm not sure this is a complete fix. The correct way to fix this would be to correct the generated files as well. Sorry I know that means it will be harder to get done.

[johanbrandhorst]

I don't think we can merge this as is - dep will still add the old dependency to the lockfile since some of the checked in files import it. We need this to be solved in the generator first (or run a post-generate script to replace the import ourselves...). Have you raised an issue with swagger-codegen?

[dmitris]

related (for reference) - go-resty/resty#178

also https://github.com/go-resty/resty/blob/master/go.mod#L1 contains module gopkg.in/resty.v1

[johanbrandhorst]

Did you regenerate these files or just search replace?

[dmitris]

@johanbrandhorst - search-replaced in the branch for now

opened swagger-api/swagger-codegen#8798 - please add the details as needed.

It would be great if we could move to using the latest version of swagger-codegen (2.3.1) as mentioned in #254. Currently when I try to generate code with swagger-codegen 2.3.1, I'm getting invalid Go generated:

./examplepb_a_bit_of_everything.go:48:13: undefined: ExamplepbNumericEnum
./examplepb_a_bit_of_everything.go:50:17: undefined: PathenumPathEnum
./examplepb_a_bit_of_everything.go:68:22: undefined: ExamplepbNumericEnum
./examplepb_a_bit_of_everything.go:78:22: undefined: ExamplepbNumericEnum

If I understand it correctly, `a_bit_of_everything.swagger.json has definitions for the lower-case fields:

    "examplepbNumericEnum": {
      "type": "string",
      "enum": [
        "ZERO",
        "ONE"
      ],
      "default": "ZERO",
      "description": "NumericEnum is one or zero.\n\n - ZERO: ZERO means 0\n - ONE: ONE means 1"
    },
    "pathenumPathEnum": {
      "type": "string",
      "enum": [
        "ABC",
        "DEF"
      ],
      "default": "ABC"
    },

which becomes in examplepb_numeric_enum.go:

// ExamplepbNumericEnum : NumericEnum is one or zero.   - ZERO: ZERO means 0  - ONE: ONE means 1
type examplepbNumericEnum string

and contradicts usage as in the following enum:

// ExamplepbNumericEnum : NumericEnum is one or zero.   - ZERO: ZERO means 0  - ONE: ONE means 1
type examplepbNumericEnum string

// List of examplepbNumericEnum
const (
	ZERO ExamplepbNumericEnum = "ZERO"
	ONE  ExamplepbNumericEnum = "ONE"
)

[johanbrandhorst]

I think we're more likely just to drop this dependency than update the version. I reiterate though - this will only happen after #772 has been merged.

[johanbrandhorst]

I'm gonna close this, lets resume the discussion in #254