-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-generate go_repository rules. #957
Conversation
Will the existing CI tests pick up if this gets out of sync with |
Codecov Report
@@ Coverage Diff @@
## master #957 +/- ##
=======================================
Coverage 53.23% 53.23%
=======================================
Files 40 40
Lines 3999 3999
=======================================
Hits 2129 2129
Misses 1672 1672
Partials 198 198 Continue to review full report at Codecov.
|
No. |
How about rerunning the generation script in CI and git diffing? Not sure we care about keeping the comments. If there's a better way just do that but I think it'd be nice to ensure it's kept in sync. |
update-repos has a great flag that can be set by the WORKSPACE directive
then we could centralize all that logic into a file that is basically the same as a |
Sorry for not responding earlier. If you want to depend on a specific commit, I've been holding the release until Go module support is more fleshed out. bazel-contrib/bazel-gazelle#477 is the last important thing, but most people won't need that. It should be done soon. |
@jayconrod, looks like bazel-contrib/bazel-gazelle@72ba271 is the commit to pin to, is that correct? |
@achew22 Yep, that fixes the issue. Let me know if you run into any problems. |
The rules are autogenerated with:
And I manually rearranged and added the comment. This is quite messy, maybe @achew22 has an idea how it could be improved.