Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the audit logger interfaces their own package inside of
authz
. Since the package is namedaudit
, I changed all instance ofAuditLogger
to justLogger
.This is necessary to avoid a circular dependency.
rbac_engine.go
needs to import thisaudit
package so it can manage the logger interfaces and call them during the authorization decision. On the master branch, adding an import for theauthz
package causes the following import cycle error:While technically a breaking change, this is both experimental and merged a few days ago.
RELEASE NOTES: none