Skip to content

Commit

Permalink
services: Don't track code coverage of reflection.v1 gencode
Browse files Browse the repository at this point in the history
Generated code for v1alpha was ignored, but not v1. Ignoring v1 reduces
lines being checked from 16,145 to 6,303, significantly improving the
overall code coverage and removing noise. This was noticed because there
was a very clear drop at 0aa976c visible in the coveralls.io coverage
graph, the point when v1 was introduced.
  • Loading branch information
ejona86 committed Nov 15, 2024
1 parent 1f159d7 commit 5431bf7
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions services/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ tasks.named("jacocoTestReport").configure {
'**/io/grpc/binarylog/v1/**',
'**/io/grpc/channelz/v1/**',
'**/io/grpc/health/v1/**',
'**/io/grpc/reflection/v1/**',
'**/io/grpc/reflection/v1alpha/**',
])
}
Expand Down

0 comments on commit 5431bf7

Please sign in to comment.