Skip to content

Commit

Permalink
Add "#server" as dataplane target value for xDS enabled gRPC servers. (
Browse files Browse the repository at this point in the history
…#11715)

As mentioned in [A71 xDS Fallback]( https://github.com/grpc/proposal/blob/master/A71-xds-fallback.md#update-csds-to-aggregate-configs-from-multiple-xdsclient-instances):
updated dataplane target to "#server" for xDS-enabled gRPC servers.
  • Loading branch information
DNVindhya authored Nov 27, 2024
1 parent 0192bec commit ebb43a6
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions xds/src/main/java/io/grpc/xds/XdsServerWrapper.java
Original file line number Diff line number Diff line change
Expand Up @@ -172,9 +172,7 @@ public void run() {

private void internalStart() {
try {
// TODO(dnvindhya): Add "#server" as "grpc.target" attribute value for
// xDS enabled servers.
xdsClientPool = xdsClientPoolFactory.getOrCreate("", new MetricRecorder() {});
xdsClientPool = xdsClientPoolFactory.getOrCreate("#server", new MetricRecorder() {});
} catch (Exception e) {
StatusException statusException = Status.UNAVAILABLE.withDescription(
"Failed to initialize xDS").withCause(e).asException();
Expand Down

0 comments on commit ebb43a6

Please sign in to comment.