Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The JWT cloud-to-prod auth interop test is failing #2680

Closed
murgatroid99 opened this issue Jan 31, 2017 · 0 comments · Fixed by #2683
Closed

The JWT cloud-to-prod auth interop test is failing #2680

murgatroid99 opened this issue Jan 31, 2017 · 0 comments · Fixed by #2683

Comments

@murgatroid99
Copy link
Member

https://grpc-testing.appspot.com/job/gRPC_interop_master/10740/testReport/(root)/tests/cloud_to_prod_auth_default_java_jwt_token_creds/
This was referenced Feb 1, 2017
Merged
Merged
Merged
Closed
ejona86 added a commit to ejona86/grpc-java that referenced this issue Feb 1, 2017
@ejona86
interop-testing: overrideAuthority breaks JWT
1d8d7d7 
Commit 65e4d9f caused grpc/grpc#9497 and grpc#2680 (dup). It is believed to
be because the JWT does not see the authority passed to
overrideAuthority. So the changes to interop-testing client are
temporarily reverted here. Note that this breaks GRPC_PROXY_EXP testing,
so the incompatibility needs to be resolved.

Solving grpc#2682 will allow reverting this change.
ejona86 added a commit to ejona86/grpc-java that referenced this issue Feb 1, 2017
@ejona86
interop-testing: overrideAuthority breaks JWT
3b9ac7a 
Commit 65e4d9f broke the jwt_token_creds. It is believed to be because
the JWT does not see the authority passed to overrideAuthority. So the
changes to interop-testing client are temporarily reverted here. Note
that this breaks GRPC_PROXY_EXP testing, so the incompatibility needs to
be resolved.

Solving grpc#2682 will allow reverting this change.

Fixes grpc/grpc#9497
Fixes grpc#2680
@ejona86 ejona86 mentioned this issue Feb 1, 2017
Merged
ejona86 added a commit that referenced this issue Feb 1, 2017
@ejona86
interop-testing: overrideAuthority breaks JWT
57b9105 
Commit 65e4d9f broke the jwt_token_creds. It is believed to be because
the JWT does not see the authority passed to overrideAuthority. So the
changes to interop-testing client are temporarily reverted here. Note
that this breaks GRPC_PROXY_EXP testing, so the incompatibility needs to
be resolved.

Solving #2682 will allow reverting this change.

Fixes grpc/grpc#9497
Fixes #2680
@lock lock bot locked as resolved and limited conversation to collaborators Sep 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

interop-testing: overrideAuthority breaks JWT ejona86/grpc-java
1 participant
@murgatroid99