Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core, services, util: export util from core and move gson dep to services for the checkUpperBoundDeps error #10390

Merged
merged 1 commit into from
Jul 20, 2023
Merged

core, services, util: export util from core and move gson dep to services for the checkUpperBoundDeps error #10390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,6 @@ java_library(
exports = [
":internal",
"//api",
"//inprocess",
"//util",
],
)
4 changes: 2 additions & 2 deletions services/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ dependencies {
libraries.guava.jre // JRE required by protobuf-java-util

runtimeOnly libraries.errorprone.annotations,
libraries.j2objc.annotations // Explicit dependency to keep in step with version used by guava

libraries.j2objc.annotations, // Explicit dependency to keep in step with version used by guava
libraries.gson // to fix checkUpperBoundDeps error here
compileOnly libraries.javax.annotation
testImplementation project(':grpc-testing'),
libraries.netty.transport.epoll, // for DomainSocketAddress
Expand Down
1 change: 0 additions & 1 deletion util/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ dependencies {

implementation libraries.animalsniffer.annotations,
libraries.guava
runtimeOnly libraries.gson // to fix checkUpperBoundDeps error in services
testImplementation testFixtures(project(':grpc-api')),
testFixtures(project(':grpc-core')),
project(':grpc-testing')
Expand Down