Skip to content

Commit

Permalink
Merge pull request #1933 from murgatroid99/grpc-js_channel_option_tra…
Browse files Browse the repository at this point in the history
…cing_1.4.x

grpc-js: Add tracing of channel options in channel and subchannel constructors (1.4.x)
  • Loading branch information
murgatroid99 authored Oct 12, 2021
2 parents b904997 + 7564f60 commit d1aac29
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/grpc-js/src/channel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ export class ChannelImplementation implements Channel {
new MaxMessageSizeFilterFactory(this.options),
new CompressionFilterFactory(this),
]);
this.trace('Constructed channel');
this.trace('Channel constructed with options ' + JSON.stringify(options, undefined, 2));
}

private getChannelzInfo(): ChannelInfo {
Expand Down
2 changes: 1 addition & 1 deletion packages/grpc-js/src/subchannel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ export class Subchannel {
this.channelzRef = registerChannelzSubchannel(this.subchannelAddressString, () => this.getChannelzInfo());
this.channelzTrace = new ChannelzTrace();
this.channelzTrace.addTrace('CT_INFO', 'Subchannel created');
this.trace('Subchannel constructed');
this.trace('Subchannel constructed with options ' + JSON.stringify(options, undefined, 2));
}

private getChannelzInfo(): SubchannelInfo {
Expand Down

0 comments on commit d1aac29

Please sign in to comment.