-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test] Do not use importlib find_module API, removed in Python 3.12 #33506
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for these 3.12 fixes!
Looks like there's a minor import issue:
|
e6748b3
to
f8f4d0c
Compare
Thanks. I’ve added |
This API was removed in Python 3.12 (python/cpython#98040). Fixes Python 3.12 support in grpcio tests.
Do not use importlib find_module API in bazel/_gevent_test_main.py This API was removed in Python 3.12 (python/cpython#98040).
f8f4d0c
to
efd45b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
This API was removed in Python 3.12.
Fixes Python 3.12 support in
grpcio
tests.This is relevant to #33063.
See also #33492.
I have actually only tested this in a form backported to grpc 1.48.4, and I am not able to test the change to
bazel/_gevent_test_main.py
directly. However, the backported form allows me to build grpc 1.48.4 for Fedora Rawhide with Python 3.12, and I believe the version in this PR to be correct—especially, if CI passes for Python 3.11, I believe this part of the test code will continue to work in Python 3.12.