Add the possibility to pass a name to the module when AMD option is true #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzin
added a commit
to bzin/grunt-contrib-handlebars
that referenced
this pull request
Jan 10, 2016
bzin
added a commit
to bzin/grunt-contrib-handlebars
that referenced
this pull request
Jan 11, 2016
bzin
added a commit
to bzin/grunt-contrib-handlebars
that referenced
this pull request
Jan 11, 2016
|
I need this feature troo good job :) |
|
Please fix conflicts and merge this. I need this feature too! |
bjrothman
approved these changes
Sep 22, 2016
|
@bjrothman I fixed the issues by updating my fork but I do not think the gruntjs team is going to review this PR soon. It is already open since January. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to pass a name into the module for a project that has requirejs and handlebars. Giving a name to the module is a requirement for my project and in this way I can have multiple and different precompiled template files.