Skip to content

Commit

Permalink
upgrade to uglify-js 3.5.0 (#534)
Browse files Browse the repository at this point in the history
  • Loading branch information
@alexlamsl
alexlamsl authored Mar 21, 2019
1 parent 33724cd commit 1e40037
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"dependencies": {
"chalk": "^2.4.1",
"maxmin": "^2.1.0",
"uglify-js": "~3.4.8",
"uglify-js": "^3.5.0",

This comment has been minimized.

Sign in to view

Copy link
@XhmikosR

XhmikosR Mar 21, 2019

Member

@alexlamsl: this was done intentionally because in many cases things broke upstream. It's OK to have this now, I wanted to let you know of the reasoning behind this.
"uri-path": "^1.0.0"
},
"devDependencies": {
Expand Down

2 comments on commit 1e40037

@XhmikosR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexlamsl: also this change was wrong since you didn't update package-lock.json.

@alexlamsl
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XhmikosR noted - will do so from now on.

Please sign in to comment.