Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for reserveDOMCache option #565

Closed
evilaliv3 opened this issue Mar 28, 2022 · 1 comment · Fixed by #566
Closed

Add documentation for reserveDOMCache option #565

evilaliv3 opened this issue Mar 28, 2022 · 1 comment · Fixed by #566

Comments

@evilaliv3
Copy link
Contributor

By looking at the default options recommended i've found the reserveDOMCache option and i just noticed that it is not documented.

This ticket is to kindly ask for a clarification about this functionality and when it is recommended to enable it so that we could work on improving the documentation: https://github.com/gruntjs/grunt-contrib-uglify/blob/main/docs/uglify-options.md

Thank you!
@alexlamsl
Copy link
Contributor

I believe that's a typo − it should be reserveDOMProperties:
https://github.com/gruntjs/grunt-contrib-uglify/blob/v5.1.0/README.md#reservedomproperties

Feel free to submit a Pull Request to fix the documentation.

evilaliv3 added a commit to evilaliv3/grunt-contrib-uglify that referenced this issue Mar 28, 2022
@evilaliv3
Fix documentation in relation to issue gruntjs#565
d9d96a5
@evilaliv3 evilaliv3 mentioned this issue Mar 28, 2022
Merged
@alexlamsl alexlamsl linked a pull request Mar 30, 2022 that will close this issue
Fix documentation in relation to issue #565 #566
Merged
alexlamsl pushed a commit that referenced this issue Mar 30, 2022
@evilaliv3
Fix documentation in relation to issue #565 (#566)
98b4c5f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix documentation in relation to issue #565 evilaliv3/grunt-contrib-uglify
2 participants
@evilaliv3 @alexlamsl