Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved binary/text files identification #176

Merged
merged 4 commits into from
Mar 27, 2024
Merged

Improved binary/text files identification #176

merged 4 commits into from
Mar 27, 2024

Conversation

denis256
Copy link
Member

@denis256 denis256 commented Mar 26, 2024 •
edited
Loading

Description

Improving binary/text file identification

Included changes:

  • Use of github.com/gabriel-vasile/mimetype (MIT license) library to identify if files are binary or text
  • Added more tests to validate identification of text files

Fixes #126.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Updated text file identification to use github.com/gabriel-vasile/mimetype library.

Migration Guide

@denis256 denis256 marked this pull request as ready for review March 26, 2024 21:56
brikis98
brikis98 approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nice find! LGTM.

@denis256 denis256 changed the title Improving binary/text files identification Improved binary/text files identification Mar 27, 2024
@denis256 denis256 merged commit f68f2a8 into master Mar 27, 2024
3 checks passed
@denis256 denis256 deleted the bug/mime-fix-126 branch March 27, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brikis98 brikis98 brikis98 approved these changes

@james03160927 james03160927 Awaiting requested review from james03160927

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do a better job of disambiguating between text and binary
2 participants
@denis256 @brikis98