Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always enable AWS shared configuration file support #123

Merged

Conversation

jtdoepke
Copy link
Contributor

@jtdoepke jtdoepke commented Apr 27, 2021

Similar to what Hashicorp has done in Terraform (hashicorp/aws-sdk-go-base#38), always enable AWS shared configuration file support. This way the AWS_SDK_LOAD_CONFIG env var no longer needs to be set to use named profiles.

Similar to what Hashicorp has done in Terraform
(hashicorp/aws-sdk-go-base#38), always enable
AWS shared configuration file support. This way the
`AWS_SDK_LOAD_CONFIG` env var no longer needs to be set.
@jtdoepke jtdoepke requested a review from yorinasub17 as a code owner April 27, 2021 01:42
Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution and apologies for the delay in reviewing! This makes sense to me, and build passed, so will go ahead and merge this in!

@yorinasub17 yorinasub17 merged commit b4fb108 into gruntwork-io:master May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants