Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find better markdown parser/convertor #30

Closed
gsantner opened this issue Sep 25, 2017 · 6 comments
Closed

Find better markdown parser/convertor #30

gsantner opened this issue Sep 25, 2017 · 6 comments

Comments

@gsantner
Copy link
Owner

gsantner commented Sep 25, 2017

Anddown lacks a lot of functionalities. It would be better to replace it with something more powerful. But it should still be lightweight and not a fully bloated library like RxMarkdown, which would pull in RxJava and son on.

@KabbAmine
Copy link

Have you considered commonmark-java? Looks like a promising library and quite extensible.

Note that I'm not a java developer, so I'm just assuming from their README that it may be what you need

@sjmduncan
Copy link
Contributor

commonmark-java does look promising, and also like a drop-in replacement for AndDown. I'll see how it performs.

@gsantner
Copy link
Owner Author

@sjmduncan Does it support highlighting too? Having both with the catch of one replacement would even be better :D (but no must)

@sjmduncan
Copy link
Contributor

@gsantner Would be nice! It seems possible even!

It might not be all that easy. There's some relevant discussion here here and a fork which addresses that issue (but has lower performance). There's also the extension API. I haven't looked at anything in much detail yet.

@sjmduncan
Copy link
Contributor

I've replaced AndDown with commonmark-java since it was mostly trivial, the one drawback is that it's a little slower.

I've started looking to use it for syntax highlighting but haven't decided what the best way to do that is. For the moment syntax highlighting won't quite match the preview.

@gsantner
Copy link
Owner Author

I think in Markor the preview can be slow, as it is done once, so no problem. At edit highlighting it is important to be fast.

subkanthi pushed a commit to subkanthi/markor that referenced this issue May 5, 2018
* Swapped AndDown for commonmark-java.

* Remove ghetto timer-profiling

* re-enable strike-through
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants