Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small features and improvements #2176

Merged
merged 18 commits into from
Feb 16, 2024

Conversation

harshad1
Copy link
Collaborator

@harshad1 harshad1 commented Dec 4, 2023

This PR includes a bunch of small features and improvements:

  1. Surrounding text with delimiters (for example markdown bold) happens in 1 step. This makes undo easier
  2. Removing surrounding delimiters is also made slightly better (select text and press corresponding action)
  3. Long press bold, italic, strikethrough to make the whole selected line strikethrough etc
    • Only for markdown
  4. The up and down arrow buttons now repeat. Can hold them to move selected line(s) up and down easily
  5. There is an option in the file menu to show the currently open document in the file explorer
  6. Can add multiple files to favourites in multi select mode
  7. Added option to share path of currently open file
  8. The select snippet directory option will now show the selected path
  9. Reorganized how actions are specified in derived action button classes. Common actions are moved to ActionButtonBase.

@harshad1 harshad1 changed the title WIP: Small features and improvements Small features and improvements Dec 23, 2023
@harshad1
Copy link
Collaborator Author

This is now ready

@gsantner
Copy link
Owner

Sorting by filesize seems to be broken currently. Guess due the sort-key changes. Can you reproduce that?

@harshad1
Copy link
Collaborator Author

harshad1 commented Feb 3, 2024

@gsantner I completely missed your comment re file sorting. This is fixed. Added zero padding to solve it.

@harshad1
Copy link
Collaborator Author

harshad1 commented Feb 9, 2024

@gsantner This is ready to merge. Please let me know if you need changes.

I will try and keep these smaller and split them up in the future :)

Copy link
Owner

@gsantner gsantner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gsantner gsantner merged commit a6cbc10 into gsantner:master Feb 16, 2024
1 check passed
@gsantner gsantner added this to the Markor v2.12 milestone Feb 16, 2024
@harshad1 harshad1 deleted the small_features_and_improvements branch August 18, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileBrowser: File list adapter sometimes doesn't set state properly
2 participants