-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Jest Tests to TypeScript #732
Conversation
✔️ Deploy Preview for sg-orbit ready! 🔨 Explore the source changes: ca9d28b 🔍 Inspect the deploy log: https://app.netlify.com/sites/sg-orbit/deploys/6124244ff69eca0008ee86e4 😎 Browse the preview: https://deploy-preview-732--sg-orbit.netlify.app |
✔️ Deploy Preview for sg-storybook ready! 🔨 Explore the source changes: ca9d28b 🔍 Inspect the deploy log: https://app.netlify.com/sites/sg-storybook/deploys/6124244f546c6b00086a5f95 😎 Browse the preview: https://deploy-preview-732--sg-storybook.netlify.app |
tsconfig.json
Outdated
"noEmit": true | ||
"noEmit": true, | ||
"baseUrl": ".", | ||
"paths": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These paths are only for tests. Should we create a special config only for testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I think that would be better, I guess you could inherit from the "common" configuration and extend it with the jest specific paths without duplicating any config?
How would you then tell Jest to use it's custom tsconfig?
✔️ Deploy Preview for sg-storybook ready! 🔨 Explore the source changes: 4b441dd 🔍 Inspect the deploy log: https://app.netlify.com/sites/sg-storybook/deploys/61253d6ad87e9b00072a3ca7 😎 Browse the preview: https://deploy-preview-732--sg-storybook.netlify.app |
✔️ Deploy Preview for sg-orbit ready! 🔨 Explore the source changes: 4b441dd 🔍 Inspect the deploy log: https://app.netlify.com/sites/sg-orbit/deploys/61253d6ac857870007d332ec 😎 Browse the preview: https://deploy-preview-732--sg-orbit.netlify.app |
# Conflicts: # tsconfig.json
Convert Jest Tests to TypeScript
Issues encountered :