Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add :recursive option #128

Closed

Conversation

avalanche123
Copy link

Add ability to prevent recursive directory scan by passing :recursive => false to Listen#to

Let me know what you guys think!

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 6e0a988 on avalanche123:disable-recursive-listen into 478f934 on guard:master.

@thibaudgg
Copy link
Member

Hi Bulat, thanks for the PR!

I'm not sure this would be a good idea because recursive option is only used by the polling adapter, what do you want to achieve here? Maybe using ignore option would be more appropriate?

@avalanche123
Copy link
Author

Unfortunately even when using :ignore option, listen recursively scans all
directories. This prevents recursive scan and allows to listen to changes
of files in target directory only, ignoring subdirectories. This feature is
listed in readme as planned but not implemented.

Bulat

On Jul 15, 2013, at 4:53, Thibaud Guillaume-Gentil [email protected]
wrote:

Hi Bulat, thanks for the PR!

I'm not sure this would be a good idea because recursive option is only
used by the polling adapter, what do you want to achieve here? Maybe using
ignore option would be more appropriate?


Reply to this email directly or view it on
GitHubhttps://github.com//pull/128#issuecomment-20964850
.

@thibaudgg
Copy link
Member

Yeah, the "Non-recursive directory scanning" pending feature could be implemented in 2.x, but not with the recursive => false option. I was more thinking in something like scan_deep_level option (#111)... will see.

@avalanche123
Copy link
Author

Got it, feel free to close

Bulat

On Jul 16, 2013, at 0:41, Thibaud Guillaume-Gentil [email protected]
wrote:

Yeah, the "Non-recursive directory scanning" pending feature could be
implemented in 2.x, but not with the recursive => false option. I was more
thinking in something like scan_deep_level option
(#111#111)...
will see.


Reply to this email directly or view it on
GitHubhttps://github.com//pull/128#issuecomment-21026048
.

@thibaudgg thibaudgg closed this Jul 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants