Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade to 2.7 in warning message. #276

Closed
wants to merge 1 commit into from
Closed

Downgrade to 2.7 in warning message. #276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions lib/listen/record/symlink_detector.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,18 @@ class SymlinkDetector
selecting watched directories (e.g. Guard has a `-w` option, Compass
allows you to specify multiple input/output directories, etc.)

2) reorganize your project so that watched directories do not
2) Downgrade to the 2.7.x listen gem. You can lock this into your
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a better solution than freezing, so it should be close to the top. Freezing the version is not a recommended solution - it's only a last resort.

Gemfile:

gem "listen", "~> 2.7"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to lock to 2.7, the pessimistic version constraint here needs the patch number, or it will let you upgrade to 2.8, 2.9, 2.10 and so on.


IMPORTANT: Version 2.8 fixes performance and reliability issues
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is necessary - probably makes it longer. I'd probably say something like "if it's too difficult or inconvenient to reorganize your project at this moment, you can temporarily freeze your version to".

present in 2.7 (see: https://github.com/guard/listen/pull/273)

3) reorganize your project so that watched directories do not
contain symlinked directories

3) submit patches so that Listen can reliably and quickly (!)
4) submit patches so that Listen can reliably and quickly (!)
detect symlinks to already watched read directories, skip
them, and then reasonably choose which symlinked paths to
report as changed (if any)
Expand Down