Plumb Silencer.new and use it #542 spec #544
Conversation
|
@ElMassimo Here's the follow-up PR from #542. Look good? |
ColinDKelley
force-pushed
the
plumb-silencer-new-and-use-it-#542-spec
branch
from
ffc0608
to
2750b38
Compare
|
Excellent, thanks Colin! |
ColinDKelley
changed the title
|
Merging this now since few tests are broken without it. |
|
BTW, I'm expecting to release this in v3.7.0 in the coming week. |
| attr_accessor :only_patterns, :ignore_patterns | ||
|
|
||
| def initialize | ||
| configure({}) | ||
| def initialize(options = {}) |
There was a problem hiding this comment.
I'm not sure the backwards compatibility constraints but you should prefer **options.
There was a problem hiding this comment.
All previous cases initialized this object with no arguments, so I don't think there's a concern there.
Can you help me understand what cases will work better with **options vs. options = {}?
There was a problem hiding this comment.
I know that **options is effective at collecting the options hash as the last argument when there are many arguments. But with a single argument like this, I'm not seeing a difference between **options and options = {}?
There was a problem hiding this comment.
Maybe **options is preferred because it always works regardless of other arguments before it?
I switched over to it here: 32bb3a7
ignore!: [/\A\.ignored/]silencer option inrecord_specso we're not depending onSilencer's defaults.Silencerto allow its config to be passed intoinitializerather than mutated byconfigure. Update some comments there about deprecating mutation.