Revert version.sbt to 1.0.40-SNAPSHOT #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our automated workflow failed partway through and left the version.sbt in a bad state.
rtyley
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Yep, this looks good! Definitely the best fix for this problem, especially as no git tag for 1.0.40 has been pushed.
What's interesting is that really, getting into this situation, where you need to revert a commit, should not be necessary - as mentioned in the issue below, it would be better if gha-scala-library-release-workflow did an initial check that the signing key was good before it started doing changes that require manual recovery steps (like updating the default branch):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our automated release workflow failed partway through because of an expired key which has since been rectified. However, the workflow did succeed far enough to make this commit which removes the snapshot suffix. Subsequently, when I tried to run the release again, it failed as it was expecting the "snapshot" suffix. This PR essentially reverts that commit so we can give the release another go.