-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Array<Long> is not supported in query parameters #190
Comments
Quick workaround: |
@blast-hardcheese if I wanted to fix this where should I start looking? |
@plapinsc Which version of guardrail was this happening on? @rtfpessoa Depending on the answer, likely That being said, this got upended in 0.44.0 due to the switch to OpenAPI 3.x; to save yourself some effort, I'd check to make sure this is still broken in master (or with what's in #192, as that'll be reviewed and merged at some point this week). The easiest way to test this would be to just modify |
Our guardrail version is: |
At least a handful of versions before and including |
@blast-hardcheese seems like this still happens in |
Excellent! Feel free to follow up here if things are not going as you expect, I may be able to dig up some more pointers |
@blast-hardcheese tried to look into this today but never had to work with a free codebase and following the flow seems quite hard to grasp. The only things I was able to check was that the initial array seems fine, but then when propMeta is invoked the items type change to string somehow. |
A passable tool for debugging local issues is to Narrowing it down to |
#1407 resolves this |
Pardon for the delay here, this is now resolved. |
The following swagger definition:
generates a method with
Iterable[String]
input parameters instead ofIterable[Long]
:def wtf(respond: Resource.wtfResponse.type)(id: Option[Iterable[String]] = None): scala.concurrent.Future[Resource.wtfResponse]
the expected result is:
def wtf(respond: Resource.wtfResponse.type)(id: Option[Iterable[Long]] = None): scala.concurrent.Future[Resource.wtfResponse]
To quickly mitigate the issue, I wanted to implement it with String and parse long by myself, but:
#184
The text was updated successfully, but these errors were encountered: