-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace strings with schema type resolvers #1407
Replace strings with schema type resolvers #1407
Conversation
d3d85f9
to
05904b3
Compare
Codecov Report
@@ Coverage Diff @@
## master #1407 +/- ##
==========================================
+ Coverage 83.19% 83.28% +0.08%
==========================================
Files 88 88
Lines 5464 5510 +46
Branches 151 142 -9
==========================================
+ Hits 4546 4589 +43
- Misses 918 921 +3
Continue to review full report at Codecov.
|
The one caveat to this approach is that it (finally?) unifies the Scala server generators (akka-http and http4s) under This is a pretty significant breaking change, but hopefully a desirable one from the perspective of both consistency and speed, as well as by using a distinct collection instead of an interface, we now get typeclass instances from cats. Due to the fairly idiosyncratic |
Also resolves #738 |
05904b3
to
4a550ae
Compare
This is blocked by actually writing the scalafix rule to replace |
4a550ae
to
f5cefbf
Compare
f5cefbf
to
5d87508
Compare
Alright, scalafix rule was submitted: scala-steward-org/scala-steward#2612 |
Continuing the work started in #1359, push the resolvers down and adding more structure (
ReifiedRawType
hierarchy for influencing generators)Schema[_]
further down instead of just the(rawType: Option[String], rawFormat: Option[String])
pairSchema[_]
forgetDefault
(Schema[_], Components) => Schema[_]
for dereferencing$ref