Resolve 1904 #1905
Merged
Resolve 1904 #1905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blast-hardcheese
added
bug
blast-hardcheese
force-pushed
the
resolve-1904
branch
from
2fa8b3e to
b3e0edd
Compare
blast-hardcheese
added a commit
to blast-hardcheese/guardrail
that referenced
this pull request
Dec 26, 2023
blast-hardcheese
added a commit
to blast-hardcheese/guardrail
that referenced
this pull request
Dec 26, 2023
blast-hardcheese
added a commit
to blast-hardcheese/guardrail
that referenced
this pull request
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1904
oneOf, when used inproperties, emits broken code.This PR unfortunately ran into an issue with
PropMeta, whereinModelResolverhas no way to distinguish between guardrail-generated models and just other types that exist on the JVM. I worked around this by testing whether the type is leading with the fully-qualified to the wrapping class.Relying on tests to keep this working for now, until a ModelResolver refactor.