Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace JSR310 injection providers with DW AbstractParam #506

Merged

Conversation

kelnos
Copy link
Member

@kelnos kelnos commented Dec 19, 2019

We can't use DW's built-in AbstractParam subclasses because they always return a JSON error response that can't be overridden in service code without a lot of pain.

This also allows us to avoid needing separate guardrail modules for DW7-9 and DW10+, as the JSR310 AbstractParam subclasses are in separate artifacts and have different package names for the two version ranges.

Addresses #239

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

We can't use DW's built-in AbstractParam subclasses because they always
return a JSON error response that can't be overridden in service code
without a lot of pain.
@kelnos
Copy link
Member Author

kelnos commented Dec 19, 2019

Hmm, it looks like the http4s tests are failing now (compiling the new test spec) due to ambiguous implicits. @blast-hardcheese any ideas?

Taking the approach from guardrail-dev#291, extending it by deduplicating terms
@blast-hardcheese blast-hardcheese force-pushed the dw-datetime-use-abstractparam branch from 9d93d5a to 8a3348d Compare December 19, 2019 16:15
@kelnos
Copy link
Member Author

kelnos commented Dec 19, 2019

Excellent, you did indeed have ideas :D

@blast-hardcheese blast-hardcheese mentioned this pull request Dec 20, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants