fix test_ll for new llguidance with working advance_parser() #1013
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have fixed the
LLInterpreter.post_process()
method to be the same asLLInterpreter.advance_parser()
- they now actually correctly compute the new forced tokens after sampled token (before they would just return the sampled token and only next call toLLInterpreter.mid_process()
would return the forced tokens).The change above broke "my" test_ll.py - this fixed it (the test works now with both new and old llguidance). It didn't seem to break anything else (@hudson-ai told me that the new behavior was what he expected anyways).
One day I have to move this test to
llguidance
repo, but it's hard since I don't have any ergonomic way of producing the llguidance grammars there.cc @Harsha-Nori