[Bug] Ensure grammar.match raises appropriately on incomplete input
#1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hudson-ai
changed the title
grammar.match raises appropriately on incomplete inputgrammar.match raises appropriately on incomplete input
|
@riedgar-ms would you mind taking a quick glance at the introduced test (which fails on main)? |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1016 +/- ##
==========================================
- Coverage 70.14% 61.30% -8.84%
==========================================
Files 62 62
Lines 4441 4443 +2
==========================================
- Hits 3115 2724 -391
- Misses 1326 1719 +393 ☔ View full report in Codecov by Sentry. |
riedgar-ms
reviewed
Sep 10, 2024
Yeah, this passes all tests for me locally -- just an edge case we hadn't covered before. Thanks for the feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force-feed
ByteParseran EOS token if it's not done by the time all input has been consumed. This lets us raise an exception when a string fails to complete a grammar