Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Try to get PR Gate working again... #1048

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

hudson-ai
Copy link
Collaborator

Our test test_repeat_calls is now failing on even more model/OS combinations. Add some additional expected failure conditions.

Long term, we may want to ditch this test. It's not really something we seem to have any control over.

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.78%. Comparing base (8af45c1) to head (828ea2e).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (8af45c1) and HEAD (828ea2e). Click for more details.

HEAD has 20 uploads less than BASE
Flag BASE (8af45c1) HEAD (828ea2e)
100 80
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1048      +/-   ##
==========================================
- Coverage   72.02%   63.78%   -8.25%     
==========================================
  Files          63       63              
  Lines        4769     4769              
==========================================
- Hits         3435     3042     -393     
- Misses       1334     1727     +393     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hudson-ai hudson-ai requested a review from riedgar-ms October 14, 2024 16:36
@hudson-ai hudson-ai merged commit 917fe35 into guidance-ai:main Oct 14, 2024
100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants