-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Expand JSON $ref
resolution
#1061
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1061 +/- ##
==========================================
- Coverage 65.33% 64.03% -1.31%
==========================================
Files 63 63
Lines 4795 4810 +15
==========================================
- Hits 3133 3080 -53
- Misses 1662 1730 +68 ☔ View full report in Codecov by Sentry. |
A couple of thoughts:
|
Yes, absolutely agreed. |
@riedgar-ms they actually note the security concern in their docs
|
$defs
, we now lazily compute grammars upon first reference.NOTE: this introduces a new dependency:
referencing
, which handles ref lookup for us (a fairly non-trivial task).