Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I91 benchmarking #105

Merged
merged 24 commits into from
Feb 22, 2023
Merged

I91 benchmarking #105

merged 24 commits into from
Feb 22, 2023

Conversation

PopcornPaws
Copy link
Contributor

@PopcornPaws PopcornPaws commented Feb 22, 2023

Description

Aims to close #91 and close #102

  • added guild and oracle pallet benchmarks
  • most user-facing pallet methods are free to call
  • only root can register new oracle operators
  • increased block time to 3 seconds from 2 seconds

Oracle operators were previously free to register by themselves, meaning that anybody could register and would immediately be assigned oracle requests. However, if they don't run the oracle binary, the oracle requests assigned to them will never be answered. Thus, only the root can register operators (so we can initially register trusted operators only).

Registered operators, however, won't automatically get oracle requests assigned; they need to activate their operator first. This means, that only active operators are assigned requests because it is assumed that registered (trusted) operators will run the oracle nodes properly after they activate their node.

Registered operators can deactivate their operator as well, which means that they remove themselves from the active operator set and don't get oracle requests assigned to them. They still remain registered (unless the root deregisters them) and can still reactivate their node and start receiving oracle requests.

Copy link
Contributor

@OnyxSkyscape OnyxSkyscape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@OnyxSkyscape OnyxSkyscape merged commit f318786 into main Feb 22, 2023
@PopcornPaws PopcornPaws deleted the I91-benchmarking branch March 10, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a method for root to deregister oracle operators Proper benchmarking + load tests
2 participants