-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I91 benchmarking #105
Merged
Merged
I91 benchmarking #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OnyxSkyscape
approved these changes
Feb 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Aims to close #91 and close #102
Oracle operators were previously free to register by themselves, meaning that anybody could register and would immediately be assigned oracle requests. However, if they don't run the oracle binary, the oracle requests assigned to them will never be answered. Thus, only the root can register operators (so we can initially register trusted operators only).
Registered operators, however, won't automatically get oracle requests assigned; they need to activate their operator first. This means, that only active operators are assigned requests because it is assumed that registered (trusted) operators will run the oracle nodes properly after they activate their node.
Registered operators can deactivate their operator as well, which means that they remove themselves from the active operator set and don't get oracle requests assigned to them. They still remain registered (unless the root deregisters them) and can still reactivate their node and start receiving oracle requests.