-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pallet-im-online storage migration #114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Excited to see this in action!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, however you should only include changes to files in
-
gn-node
-
gn-runtime
-
Cargo.toml
Changes to gn-client
, gn-wasm
and pallet-validator-manager
shouldn't be included because they revert what's currently on main.
Great job otherwise! I guess this upgrade will be split into two PRs though. The first one will be version 102 which has ()
as an im-online
"authority", then 103 will actually include the ValidatorManager
pallet as the authority.
This reverts commit 4dd0c8a.
The issue above is caused by the combination of 1accee1 and 408bf06 (which was admittedly a mistake on my part), so I will most likely have to reset to a45502a and then rebase onto main (that latter of which should've been done in the first place instead of merging from main), because I can't see a good alternative for explicitly excluding these changes without having to resort to even more cursed and unorthodox methods. |
a511f62
to
3b6af72
Compare
@OnyxSkyscape could you split this into two PRs: one for each runtime upgrade? I'm trying to write a bit about each runtime upgrade in the docs and I'd like to link to certain releases. So we should merge this PR but only if it includes changes specific to upgrade 102. Then I'll add a release tag on main related to 102. Then another PR should be opened for 103. What do you think? |
This reverts commit 19076bd.
Runtime upgrade v102 tested and successfully rolled out into prod yesterday 6pm at commit 4423dcf, ready to merge. |
Aims to close #110.
DO NOT merge until tested on development chain.