Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(EditGuildDrawer): validate eventSources with Zod #1419

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

BrickheadJohnny
Copy link
Collaborator

@BrickheadJohnny BrickheadJohnny commented Jul 29, 2024

Important: this is a hotfix. We'll need to write a proper schema for this form in our types package & use Zod for validating every field in the edit guild form.

@BrickheadJohnny BrickheadJohnny added the improvement Ui, code, scalablity, security improvements label Jul 29, 2024
@BrickheadJohnny BrickheadJohnny self-assigned this Jul 29, 2024
Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
guild-xyz ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 4:19pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
guild-xyz-storybook ⬜️ Ignored (Inspect) Jul 29, 2024 4:19pm

Copy link
Contributor

@dominik-stumpf dominik-stumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@BrickheadJohnny BrickheadJohnny merged commit e6e354b into main Jul 29, 2024
7 checks passed
@BrickheadJohnny BrickheadJohnny deleted the validate-event-sources-with-zod branch July 29, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Ui, code, scalablity, security improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants