feat: DiscordCardWarning component
#1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dovalid
reviewed
Sep 10, 2024
| import { PlatformName, PlatformType } from "types" | ||
| import PlatformAccessButton from "./PlatformAccessButton" | ||
|
|
||
| const AccessedGuildPlatformCard = () => { | ||
| const { guildPlatform } = useRolePlatform() | ||
| const rolePlatform = useRolePlatform() |
There was a problem hiding this comment.
Nit: why not keep the {guildPlatform} destruction here? Since we only use that from rolePlatform, felt cleaner to me
There was a problem hiding this comment.
Oh, good point, I originally passed down rolePlatform as a prop to the PlatformCardWarning component, but then realised that I could just use the useRolePlatform hook & just forgot to revert this change. Will do it before merging the PR, thanks!
dovalid
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a
cardWarningComponentfor Discord rewards which indicates if the original Discord role doesn't exist anymore.Also improved the code a bit:
GoogleCardWarningfromReward.tsx, we don't need that anymoreGoogleCardWarningcomponentCardWarningComponentBasecomponentNote:
We should refactor the fetching logic in the
DiscordBotPermissionsCheckercomponent, I noticed that it won't write in the/v2/discord/servers/:serverId/permissionscache, so we'll actually fetch the data 2 times in some edge cases. This is a low prio task & is not the scope of this PR, so I left it as is for now.