Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Dialog, Drawer and ResponsiveDialog components #1549

Merged
merged 7 commits into from
Nov 19, 2024
Merged

feat: Dialog, Drawer and ResponsiveDialog components #1549

merged 7 commits into from
Nov 19, 2024

Conversation

BrickheadJohnny
Copy link
Collaborator

@BrickheadJohnny BrickheadJohnny commented Nov 19, 2024 •
edited
Loading

No description provided.

@BrickheadJohnny BrickheadJohnny added the feature New feature or request label Nov 19, 2024
@BrickheadJohnny BrickheadJohnny self-assigned this Nov 19, 2024
@vercel Vercel
Copy link

vercel bot commented Nov 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
guild-xyz ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 3:45pm

@BrickheadJohnny BrickheadJohnny changed the title feat: simple dialog component feat: Dialog, Drawer and ResponsiveDialog components Nov 19, 2024
@BrickheadJohnny BrickheadJohnny marked this pull request as ready for review November 19, 2024 13:56
dominik-stumpf
dominik-stumpf requested changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@dominik-stumpf dominik-stumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest using ScrollArea to avoid out of place native style.

image

The drawer doesn't seem to have scrollable body, but if it had would pose the problem of making it hard to dismiss using a down swipe gesture. We should think about a solution for this.

@dominik-stumpf
Copy link
Contributor

Found a nice example for scrollable drawer: https://vaul.emilkowal.ski/default#scrollable

@BrickheadJohnny
Copy link
Collaborator Author

Thanks, nice catch, @dominik-stumpf!
Just pushed a commit where I use a ScrollArea component. I also removed the complex logic from the Dialog component for the scrollable body. For now, the body is always scrollable (if the content would overflow), if we'll need a scrollable modal later, we'll implement it.

dominik-stumpf
dominik-stumpf approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@dominik-stumpf dominik-stumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Added some animations, merge it if it works for you.

#1550

@BrickheadJohnny BrickheadJohnny merged commit 02174ea into v3-main Nov 19, 2024
4 checks passed
@BrickheadJohnny BrickheadJohnny deleted the dialog-component branch November 19, 2024 15:50
@dominik-stumpf dominik-stumpf mentioned this pull request Dec 9, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominik-stumpf dominik-stumpf dominik-stumpf approved these changes

Assignees

@BrickheadJohnny BrickheadJohnny

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrickheadJohnny @dominik-stumpf