Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add explorer #1555

Merged
merged 34 commits into from
Nov 22, 2024
Merged

add explorer #1555

merged 34 commits into from
Nov 22, 2024

Conversation

dominik-stumpf
Copy link
Contributor

@dominik-stumpf dominik-stumpf commented Nov 21, 2024

Mostly adapted from v2 explorer, went through some simplification, replaced SWR with react-query. In this version the header can be glitched if the page is scrolled rapidly.

  • chore: add explorer scaffolding
  • feat: add infinite scroll

Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
guild-xyz ❌ Failed (Inspect) Nov 22, 2024 8:43am

Copy link
Collaborator

@BrickheadJohnny BrickheadJohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love these changes, I left a couple of comments & I'd also bring back the sticky header as I said you today morning 😉

src/app/explorer/constants.ts Outdated Show resolved Hide resolved
guild.d.ts Show resolved Hide resolved
src/app/explorer/components/GuildCard.tsx Outdated Show resolved Hide resolved
src/app/explorer/components/InfiniteScrollGuilds.tsx Outdated Show resolved Hide resolved
src/app/explorer/components/InfiniteScrollGuilds.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@BrickheadJohnny BrickheadJohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lfg

@BrickheadJohnny BrickheadJohnny merged commit 107df80 into v3-main Nov 22, 2024
3 of 4 checks passed
@BrickheadJohnny BrickheadJohnny deleted the add-explorer branch November 22, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants