refactor: simplify the image uploader #1561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
BrickheadJohnny
changed the title
BrickheadJohnny
approved these changes
Nov 25, 2024
BrickheadJohnny
added a commit
that referenced
this pull request
Nov 25, 2024
* feat: simple guild page * feat: simple create guild page * fix: better schema names * fix(CreateGuildButton): stringify body only once * fix: use `onTouched` form mode * feat: implement image uploader, improve fetcher and error messages * feat: add background image * feat: add success and error toasts * feat(ImageUploader): `onFileInputChange` prop * fix: add `aria-required` attributes * refactor: simplify the image uploader (#1561) * fix: address typo in request pathname * feat: add option for toast instead of form message * refactor: simplify the image uploader --------- Co-authored-by: BrickheadJohnny <[email protected]> --------- Co-authored-by: Dominik Stumpf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced form error message on image uploader with toast as it's also a request like form submit. We could also remove the
FormErrorMessageand use the toast inside theControlledImageUploader. Let me know your thoughts on this one.