Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Guild, Role, RoleGroup schemas #1567

Merged
merged 4 commits into from
Nov 26, 2024
Merged

feat: Guild, Role, RoleGroup schemas #1567

merged 4 commits into from
Nov 26, 2024

Conversation

BrickheadJohnny
Copy link
Collaborator

Added some basic schemas for Guilds, Roles, RoleGroups.

@BrickheadJohnny BrickheadJohnny added the feature New feature or request label Nov 26, 2024
@BrickheadJohnny BrickheadJohnny self-assigned this Nov 26, 2024
Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
guild-xyz ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 1:43pm

Copy link
Contributor

@dominik-stumpf dominik-stumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how it follows the format of V2. We might want a comment about its intended place, which is V3.

src/lib/schemas/roleGroup.ts Outdated Show resolved Hide resolved
src/lib/schemas/common.ts Show resolved Hide resolved
src/lib/schemas/role.ts Outdated Show resolved Hide resolved
src/lib/schemas/role.ts Outdated Show resolved Hide resolved
@BrickheadJohnny BrickheadJohnny merged commit d6bab0a into v3-main Nov 26, 2024
3 of 4 checks passed
@BrickheadJohnny BrickheadJohnny deleted the basic-schemas branch November 26, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants