feat: requirement building blocks #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
BrickheadJohnny
changed the title
BrickheadJohnny
commented
Nov 28, 2024
|
|
||
| export const ChainIndicator = ({ | ||
| chain, | ||
| }: { chain: Register["config"]["chains"][number]["id"] }) => ( |
There was a problem hiding this comment.
What do you think, should we extract the Register["config"]["chains"][number]["id"] to a type somewhere?
There was a problem hiding this comment.
It looks like a common type, we can extract it into a wagmi type file.
BrickheadJohnny
commented
Nov 28, 2024
dominik-stumpf
approved these changes
Nov 28, 2024
| @@ -0,0 +1 @@ | |||
| <svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="32" height="32" viewBox="0 0 32 32"><defs><linearGradient id="eth-c" x1="50%" x2="50%" y1="0%" y2="100%"><stop offset="0%" stop-color="#FFF" stop-opacity=".5"/><stop offset="100%" stop-opacity=".5"/></linearGradient><circle id="eth-b" cx="16" cy="15" r="15"/><filter id="eth-a" width="111.7%" height="111.7%" x="-5.8%" y="-4.2%" filterUnits="objectBoundingBox"><feOffset dy=".5" in="SourceAlpha" result="shadowOffsetOuter1"/><feGaussianBlur in="shadowOffsetOuter1" result="shadowBlurOuter1" stdDeviation=".5"/><feComposite in="shadowBlurOuter1" in2="SourceAlpha" operator="out" result="shadowBlurOuter1"/><feColorMatrix in="shadowBlurOuter1" values="0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0.199473505 0"/></filter><path id="eth-e" d="M16.4977734,20.9675435 L23.9999473,16.616495 L16.4977207,26.9946245 L16.4976173,26.9943278 L9,16.6164144 L16.4977734,20.9674935 Z M16.4977471,3.00004297 L23.9954941,15.2198561 L16.4977734,19.5730917 L9,15.2198561 L16.4977471,3.00004297 Z"/><filter id="eth-d" width="123.3%" height="114.6%" x="-11.7%" y="-5.2%" filterUnits="objectBoundingBox"><feOffset dy=".5" in="SourceAlpha" result="shadowOffsetOuter1"/><feGaussianBlur in="shadowOffsetOuter1" result="shadowBlurOuter1" stdDeviation=".5"/><feComposite in="shadowBlurOuter1" in2="SourceAlpha" operator="out" result="shadowBlurOuter1"/><feColorMatrix in="shadowBlurOuter1" values="0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0.204257246 0"/></filter></defs><g fill="none" fill-rule="evenodd"><use fill="#000" filter="url(#eth-a)" xlink:href="#eth-b"/><use fill="#627EEA" xlink:href="#eth-b"/><use fill="url(#eth-c)" style="mix-blend-mode:soft-light" xlink:href="#eth-b"/><circle cx="16" cy="15" r="14.5" stroke="#000" stroke-opacity=".097"/><g fill-rule="nonzero"><use fill="#000" filter="url(#eth-d)" xlink:href="#eth-e"/><use fill="#FFF" fill-opacity="0" fill-rule="evenodd" xlink:href="#eth-e"/></g><g fill="#FFF" fill-rule="nonzero" transform="translate(9 3)"><polygon fill-opacity=".602" points="7.498 0 7.498 8.87 14.995 12.22"/><polygon points="7.498 0 0 12.22 7.498 8.87"/><polygon fill-opacity=".602" points="7.498 17.968 7.498 23.995 15 13.616"/><polygon points="7.498 23.995 7.498 17.967 0 13.616"/><polygon fill-opacity=".2" points="7.498 16.573 14.995 12.22 7.498 8.872"/><polygon fill-opacity=".602" points="0 12.22 7.498 16.573 7.498 8.872"/></g></g></svg> | |||
There was a problem hiding this comment.
For icons like this we could use an icon collection from iconify https://icon-sets.iconify.design/token-branded
They also have great react library where all of their icons are accessible. What do you think?
There was a problem hiding this comment.
Ooooh, this is a good suggestion, I'll take a look at it!
|
|
||
| export const ChainIndicator = ({ | ||
| chain, | ||
| }: { chain: Register["config"]["chains"][number]["id"] }) => ( |
There was a problem hiding this comment.
It looks like a common type, we can extract it into a wagmi type file.
| @@ -7,7 +7,7 @@ export const badgeVariants = cva( | |||
| { | |||
| variants: { | |||
| size: { | |||
| sm: "text-xs h-5", | |||
| sm: "text-xs h-5 gap-1", | |||
There was a problem hiding this comment.
I think we could have this on all sizes like on button.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Common requirement-related components & Storybook stories