Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: RewardCard component #1574

Merged
merged 2 commits into from
Dec 2, 2024
Merged

feat: RewardCard component #1574

merged 2 commits into from
Dec 2, 2024

Conversation

BrickheadJohnny
Copy link
Collaborator

No description provided.

@BrickheadJohnny BrickheadJohnny added the feature New feature or request label Nov 29, 2024
@BrickheadJohnny BrickheadJohnny self-assigned this Nov 29, 2024
Copy link

vercel bot commented Nov 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
guild-xyz ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 1:03pm

Copy link
Contributor

@dominik-stumpf dominik-stumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Changing the title, description and image to an individual component would be necessary for customization, but this should do until then.

className={cn("flex flex-col gap-4 border-2 p-4 shadow-none", className)}
>
<div className="grid grid-cols-[theme(space.9)_1fr] items-center gap-x-2 gap-y-0">
<div className="row-span-2 flex size-9 shrink-0 items-center justify-center overflow-hidden rounded-full bg-blackAlpha dark:bg-blackAlpha-hard">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to break after this on small devices so the image takes the full width of a row. Ideal place for a container query? :yolo:

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, yep, I didn't want to optimize it for every screen size until we don't see it in action hehe. Will do it later!

@BrickheadJohnny BrickheadJohnny merged commit 7f8800d into add-guild-page Dec 2, 2024
4 checks passed
@BrickheadJohnny BrickheadJohnny deleted the reward-card branch December 2, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants