Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: auth rework #1581

Merged
merged 2 commits into from
Dec 10, 2024
Merged

feat: auth rework #1581

merged 2 commits into from
Dec 10, 2024

Conversation

BrickheadJohnny
Copy link
Collaborator

Opening this PR on the rewards branch to avoid strange conflicts.

@BrickheadJohnny BrickheadJohnny added the feature New feature or request label Dec 10, 2024
@BrickheadJohnny BrickheadJohnny self-assigned this Dec 10, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
guild-xyz ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 2:38pm

dominik-stumpf
dominik-stumpf approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@dominik-stumpf dominik-stumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Why not point this at add-guild-page?

@BrickheadJohnny BrickheadJohnny changed the base branch from rewards to add-guild-page December 10, 2024 15:44
@BrickheadJohnny BrickheadJohnny changed the base branch from add-guild-page to rewards December 10, 2024 15:46
@BrickheadJohnny
Copy link
Collaborator Author

Nice work! Why not point this at add-guild-page?

We're fetching some entities differently on the rewards branch & I opened this branch from that one, so the diff is crazy if I point this PR to the add-guild-page branch. We actually need the auth for the Discord reward (which we'll implement on the rewards branch), so I thought it's okay to point this PR to that one. 😉

@BrickheadJohnny BrickheadJohnny merged commit da7220f into rewards Dec 10, 2024
4 checks passed
@BrickheadJohnny BrickheadJohnny deleted the auth-rework branch December 10, 2024 15:50
@dominik-stumpf
Copy link
Contributor

dominik-stumpf commented Dec 10, 2024 •
edited
Loading

Nice work! Why not point this at add-guild-page?

We're fetching some entities differently on the rewards branch & I opened this branch from that one, so the diff is crazy if I point this PR to the add-guild-page branch. We actually need the auth for the Discord reward (which we'll implement on the rewards branch), so I thought it's okay to point this PR to that one. 😉

Okay, I will be sure to wait until rewards before the error handling is merged.

BrickheadJohnny added a commit that referenced this pull request Dec 12, 2024
@BrickheadJohnny
feat: rewards (#1579)
8f10e63 
* feat(RewardCard): change layout with container queries

* chore: update schemas

* feat: custom reward cards for permissions and points

* feat: fetch real rewards data and add a simple reward leaderboard

* fix: remove points name for now

* feat: separate join and leave guild components

* feat: useGuild hook

* fix: add missing use client directives

* feat: auth rework (#1581)

* feat: use `https` in development

* feat: use httpOnly cookie for authenticated requests

* feat: third party auth (#1582)

* feat: 3rd party auth flow

* feat(ConnectResultToast): add toast icons

* chore: update readme

* cleanup: remove unnecessary components

* fix: invalidate queries when signing in/out

* feat: join modal

* feat: DiscordRewardCard

* cleanup(RoleCard): remove unnecessary TODO comments

* feat: better identity-related types

* fix(DiscordRewardCard): disabled state

* fix(ConnectResultToast): show toast only after platform connection

* fix(PointsRewardCard): don't use pathname for navigation

* fix(rewardCards): add proper types

* feat(leaderboard): display points' name

* feat(leaderboard): display user addresses & "Your position" section

* feat(DiscordRewardCard): more detailed tooltip message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominik-stumpf dominik-stumpf dominik-stumpf approved these changes

Assignees

@BrickheadJohnny BrickheadJohnny

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrickheadJohnny @dominik-stumpf