Finish PR #199 „Accept a function as options.name“ #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zahrevsky
changed the title
zahrevsky
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context. Two years ago @wiggisser created a PR #199 that allowed
options.nameargument to accept functions. It implemented all the functionality, but wasn't rebased and lacked some other things. Citing the discussion:PR description. This PR includes original @wiggisser commits and also updates type definitions, documentation, and rebases on top of latest commit (8c9ecc1). The rebase is simply switching test framework from Tape to Mocha. The only thing left now is to add a changelog entry.
Next step. Changelog format requires to provide a link to the latest commit and a link to the version comparison via tags. As I'm not able to create tags in this repo, and commit won't be available untill the PR is merged, I can't update the changelog. @phated could you help me with that?