Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace wreck #126

Closed
phated opened this issue Aug 19, 2017 · 7 comments
Closed

Replace wreck #126

phated opened this issue Aug 19, 2017 · 7 comments
Labels
help wanted
Milestone
2.0.0

Comments

@phated
Copy link
Member

phated commented Aug 19, 2017

There's probably a smaller and es5-friendly request library.
@timdeschryver
Copy link
Contributor

Did you had something in mind?
Because I couldn't find one at first sight, or they dropped node 0.10.

Would it be an option to write one ourselves?

@phated
Copy link
Member Author

phated commented Sep 26, 2017

@tdeschryver I don't really have any recommendations. Maybe https://www.npmjs.com/package/http-basic? Not sure if @ForbesLindesay wants to support node 0.10

@phated
Copy link
Member Author

phated commented Sep 26, 2017

Maybe https://github.com/brycebaril/client-request

@phated
Copy link
Member Author

phated commented Sep 26, 2017

Or maybe something as simple as https://github.com/fent/node-miniget

@gulpjs gulpjs deleted a comment from ForbesLindesay Oct 16, 2017
@terinjokes
Copy link

We only use it for fetching the blacklist, afaict. Why not just use the built-in HTTP client?

@phated phated closed this as completed in ea74721 Dec 7, 2017
@phated
Copy link
Member Author

phated commented Dec 7, 2017

@terinjokes can you review my implementation at ea74721?

@terinjokes
Copy link

@phated It looks reasonable to me.

@phated phated added this to the 2.0.0 milestone Dec 13, 2017
phated added a commit that referenced this issue Dec 21, 2017
@phated
Update: Replace wreck with built-in https (closes #126)
b2e64c8
phated added a commit that referenced this issue Dec 21, 2017
@phated
Update: Replace wreck with built-in https (closes #126)
4891021
phated added a commit that referenced this issue Dec 21, 2017
@phated
Update: Replace wreck with built-in https (closes #126)
91a218a
phated added a commit that referenced this issue Dec 21, 2017
@phated
Update: Replace wreck with built-in https (closes #126)
a4b842a
phated added a commit that referenced this issue Dec 21, 2017
@phated
Update: Replace wreck with built-in https (closes #126)
94f3041
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
3 participants
@terinjokes @phated @timdeschryver