Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear "task did not complete" warning when an error occurs #162

Closed
phated opened this issue May 2, 2018 · 1 comment · Fixed by #204
Closed

Clear "task did not complete" warning when an error occurs #162

phated opened this issue May 2, 2018 · 1 comment · Fixed by #204
Labels
enhancement
Milestone
3.0

Comments

@phated
Copy link
Member

phated commented May 2, 2018

Ref gulpjs/gulp#2168
@phated phated changed the title Clear "task did not complete" warning when an error occurs. Clear "task did not complete" warning when an error occurs May 2, 2018
@another-guy
Copy link

The false negatives (Did you forget to signal async completion?) reported by @MLoughry in the ref'ed issue is occurring to me to. I'm too talking specifically about the gulp.parallel(failingTask, notFailingTask) case.

Since the ref'ed issue has been closed, is this the right issue to subscribe for status notification(s)?

@phated phated added this to the 3.0 milestone Apr 20, 2019
@stof stof mentioned this issue Apr 16, 2020
Merged
phated pushed a commit that referenced this issue May 20, 2020
@stof
Fix: Avoid false positive reporting of sync tasks on errors (fixes #162…
8de7b2a 
…) (#204)
phated pushed a commit that referenced this issue May 20, 2020
@stof @phated
Fix: Avoid false positive reporting of sync tasks on errors (fixes #162…
d827191 
…) (#204)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

Fix false positive reporting of sync tasks on errors stof/gulp-cli
2 participants
@phated @another-guy