-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tailor message when local gulp is missing #155
Conversation
b483910
to
95633bd
Compare
I'm not necessarily against the modules changes but I don't recommend yarn at all. Can you remove that and I'll do a review on the other stuff alone. |
@phated yarn is great, I think those changes are fine - if somebody is using yarn we can show them yarn commands. that being said, i think most people who use yarn know to run |
The motivation behind this change was that one of my coworkers had forgotten to install before trying to run gulp, and then thought he was supposed to run Thanks! |
There's a huge history of problems with yarn that I can't hunt down and link on mobile. Also, we are pretty regularly bashed for the slow startup speed of the cli, so I'm not excited to add more fs calls. |
These Our experience with Yarn has certainly not been 100% rosy, but it's the tool we're using for right now (primarily because we're still seeing 30-50% install speed boost on Windows over npm). This change would just be accommodating folks who've already chosen to use Yarn (based on the existence of |
@phated you said "Also, we are pretty regularly bashed for the slow startup speed of the cli, so I'm not excited to add more fs calls." Do you have a link to an issue or a use case? i can take a look. |
95633bd
to
6f5447b
Compare
@phated I've removed the Yarn message (to be addressed in a separate PR), let me know if you see any other changes that you'd prefer to see. Thanks! |
When there is a package.json file but no node_modules folder, tell them to run the full install command, instead of just adding gulp
Planning to get this released with a couple of other big features and fixes! |
@bdukes thanks for this! Sorry it's taken so long to land 😢 |
🎉 no problem, @phated, thanks! |
When there is a yarn.lock file, show yarn commands instead of npm commands
When there is a package.json file but no node_modules folder, tell them to run
the full install command, instead of just adding gulp