Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve DKG assembly of physical constants #263

Merged
merged 8 commits into from
Dec 6, 2023
Merged

Conversation

cthoyt
Copy link
Member

@cthoyt cthoyt commented Nov 30, 2023

This PR does the following:

  • Adds initial values to physical constant nodes using debio:0000042 as a property (newly minted)
  • Adds formulas to physical constant nodes using debio:0000043 as a property (newly minted)
  • Adds symbols as synonyms for physical constants
  • Small cleanup of synonym type predicates in other places

When you call the API you now get

curl -X 'GET' \
  'http://localhost:8771/api/entity/wikidata%3AQ13534105' \
  -H 'accept: application/json'
{
  "id": "wikidata:Q13534105",
  "name": "electron magnetic dipole moment",
  "type": "class",
  "obsolete": false,
  "description": "spin of an electron",
  "synonyms": [
    {
      "value": "electron magnetic moment",
      "type": "oboInOwl:hasExactSynonym"
    },
    {
      "value": "\\mu _{\\mathrm {e} }",
      "type": "debio:0000031"
    }
  ],
  "xrefs": [
    {
      "id": "nist.codata:muem",
      "type": "oboinowl:hasDbXref"
    }
  ],
  "labels": [
    "constant",
    "wikidata"
  ],
  "properties": {
    "debio:0000042": [
      "-0.0000000000000000000000092847647043"
    ]
  }
}

@cthoyt cthoyt force-pushed the add-physical-values branch from 93f1185 to 98e1315 Compare November 30, 2023 15:59
@cthoyt cthoyt marked this pull request as ready for review November 30, 2023 16:43
@cthoyt cthoyt requested a review from bgyori November 30, 2023 16:44
@cthoyt cthoyt force-pushed the add-physical-values branch from 98e1315 to 2745c82 Compare December 5, 2023 17:11
Copy link
Member

@bgyori bgyori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@bgyori bgyori merged commit 3ce0dbd into main Dec 6, 2023
4 checks passed
@cthoyt cthoyt deleted the add-physical-values branch December 6, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants