Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve scenario 5 import #289

Merged
merged 5 commits into from
Feb 26, 2024
Merged

Improve scenario 5 import #289

merged 5 commits into from
Feb 26, 2024

Conversation

cthoyt
Copy link
Member

@cthoyt cthoyt commented Feb 26, 2024

This PR does the following:

  1. Adds the ability to specify a grounding map when processing vensim/pysd
  2. Updates the scenario 5 notebook to include Tenzin's grounding map
  3. Make minor fix to grounding map
  4. Make minor update to prints inside notebook
  5. Add Stockflow AMR output

TODO

  • Fix metadata export - the AMR contains something about SIR model at the moment that doesn't make sense. This was fixed by adding in an explicit Annotations object in the notebook
  • Add schema URL to stockflow export
  • Continue improving grounding map to cover more of model

Working Stockflow AMR JSON export: https://github.com/gyorilab/mira/blob/scenario-5-grounding/notebooks/hackathon_2024.02/scenario5/scenario_5_stockflow.json

@bgyori bgyori marked this pull request as ready for review February 26, 2024 16:52
@bgyori
Copy link
Member

bgyori commented Feb 26, 2024

Great, thanks!

@bgyori bgyori merged commit bf0189b into main Feb 26, 2024
4 checks passed
@bgyori bgyori deleted the scenario-5-grounding branch February 26, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants