Add support for the seekable format #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyscos
reviewed
Jan 9, 2025
There was a problem hiding this comment.
Thank you very much for the work here!
Left a couple of comments, but overall it looks very nice, and I'm looking forward to merging it.
EDIT: It seems facebook/zstd#4201 was merged back in November, but we're still waiting for a release (1.5.7?) to include it.
rorosen
force-pushed
the
init-seekable-format
branch
from
9015062 to
40111e3
Compare
|
Thanks for your review! I updated the PR according to your suggestions, let me know if there is anything else. I also think the |
gyscos
reviewed
Jan 14, 2025
gyscos
reviewed
Jan 14, 2025
gyscos
approved these changes
Jan 14, 2025
Support the seekable format through bindings to the upstream functionality in zstd-safe. The seekable format can be activated with the `seekable` feature flag.
rorosen
force-pushed
the
init-seekable-format
branch
from
40111e3 to
ab2ae11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds bindings for the seekable format to zstd-safe. Everything is behind the
seekablefeature flag, which disabled by default, and the basic functionality is covered by unit tests. In general, this is close to a 1-for-1 mapping to the seekable format C functions using rust types.However, everything around the seek table API is commented out for now. I noticed that the creation of a seek table in
ZSTD_seekTable_create_fromSeekable()(which is the only way to create a seek table) can cause a segmentation fault, if called with an uninitialized seekable. There is already a PR open upstream to fix the issue (facebook/zstd#4201). The complete seekable format can be used without access to the seek table functions without limitations, afaict they only provide advantages when working with multiple seekable archives in memory constrained environments.This feature is also requested in #272