Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken search functionality in documentation #3299

Closed
oleksiyskononenko opened this issue Jun 9, 2022 · 1 comment · Fixed by #3316
Closed

Broken search functionality in documentation #3299

oleksiyskononenko opened this issue Jun 9, 2022 · 1 comment · Fixed by #3316
Assignees
@oleksiyskononenko
Labels
bug Any bugs / errors in datatable; however for severe bugs use [segfault] label documentation
Milestone
Release 1.1.0

Comments

@oleksiyskononenko
Copy link
Contributor

oleksiyskononenko commented Jun 9, 2022 •
edited
Loading

Both locally and on readthedocs search now doesn't produce any output:

Screen Shot 2022-06-09 at 1 17 19 AM

Originally posted by @pramitchoudhary
@oleksiyskononenko oleksiyskononenko added bug Any bugs / errors in datatable; however for severe bugs use [segfault] label documentation labels Jun 9, 2022
@oleksiyskononenko oleksiyskononenko added this to the Release 1.1.0 milestone Jun 9, 2022
@oleksiyskononenko
Copy link
Contributor Author

oleksiyskononenko commented Jun 21, 2022 •
edited
Loading

Seems to be related to the sphinx version update and the custom wren theme we're using: sphinx-doc/sphinx#8623

@oleksiyskononenko oleksiyskononenko mentioned this issue Jul 20, 2022
Merged
oleksiyskononenko added a commit that referenced this issue Jul 20, 2022
@oleksiyskononenko
Fix search functionality for sphinx 4.* (#3316)
3664f0f 
Adjust our custom theme in a way similar to `sphinx_rtd_theme`, see  readthedocs/sphinx_rtd_theme#1021. This fixes the search functionality for sphinx `4.*`. We can take care of sphinx `5.*`, that was recently released later, if needed.

Closes #3299
@oleksiyskononenko oleksiyskononenko self-assigned this Jul 21, 2022
samukweku pushed a commit that referenced this issue Aug 4, 2022
@oleksiyskononenko
Fix search functionality for sphinx 4.* (#3316)
99325cf 
Adjust our custom theme in a way similar to `sphinx_rtd_theme`, see  readthedocs/sphinx_rtd_theme#1021. This fixes the search functionality for sphinx `4.*`. We can take care of sphinx `5.*`, that was recently released later, if needed.

Closes #3299
samukweku pushed a commit that referenced this issue Aug 10, 2022
@oleksiyskononenko
Fix search functionality for sphinx 4.* (#3316)
cf580ee 
Adjust our custom theme in a way similar to `sphinx_rtd_theme`, see  readthedocs/sphinx_rtd_theme#1021. This fixes the search functionality for sphinx `4.*`. We can take care of sphinx `5.*`, that was recently released later, if needed.

Closes #3299
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleksiyskononenko oleksiyskononenko

Labels
bug Any bugs / errors in datatable; however for severe bugs use [segfault] label documentation
Projects
None yet
Milestone
Release 1.1.0
Development

Successfully merging a pull request may close this issue.

Fix search functionality for sphinx 4.* h2oai/datatable
1 participant
@oleksiyskononenko