-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.ir class no longer works #1472
Comments
Feel free to propose an IR method if you think people still need one. I can't remember the last time I need to use IR for anything. |
We should remove these classes from HTML5 BP and move them to their own "helpers" repository if we want to keep them. I don't think it is necessary to have them within our code if a lot of people are not using them or rewrite them up to a certain point (as I do). |
SGTM. But I'd suggest we don't bother with creating another repo. |
👍 Might as well move the helper classes into the documentation. |
The negative text indent was bullet proof for all my applications (once I added Reverting to the previous method would work for me.
The implication here is that non-functional helper classes is a feature rather than a bug… But isn't that a separate issue? 'retire helper classes' might be a better ticket for that, nay? |
The following CSS helper classes get removed from `main.css`: * Image replacement: `.ir` * Hidden elements: `.hidden` * Visually hidden elements: `.visuallyhidden` * Visually hidden elements that are focussable via keybord: `.visuallyhidden.focusable` * Invisible elements: `.invisible` * Clearfix: `.clearfix` These classes were removed because they don't provide enough use cases within modern web development. Cases are mostly handled indiviually by developers. All code is provided in branch [`v4`](https://github.com/h5bp/html5-boilerplate/tree/v4). Reference #1472. Closes #1475.
|
This is right. Thanks. |
Explicitly setting |
|
Pretty certain I recall seeing a few things prematurely dropped, then added back in after discussion. |
I am on FF 25.0.1 (Mac) and I was getting the same issue in your jsfiddle but it seems like it's only related to button or input type="button" tags. but it works well for other tags: http://jsfiddle.net/4JhdV/4/
|
Just curious, if |
@dmathisen whenever I still need to use IR, I try to make use of the Compass mixin hide-text. So far, so good, but there are (and there will be) issues depending on the case. An example |
@arthurgouveia Right. I didn't know that the old |
jsFiddle test case (git blamed to get the latest modification and sourced that revision via rawgithub.com).
The last few iterations of
.ir
have been implemented without much discussion. Breaking edge cases are reported but the onus is always on proving the new iteration breaks rather than proving it works. Perhaps that should be the other way round, and proposals for new methods should pass a a series of tests before making origin master? Of course, running CI wouldn't be procedural (you'd still need human observation to validate)The text was updated successfully, but these errors were encountered: