Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify 32 bit CI workflow & lint, test on Go 1.19-1.22 #45

Merged
merged 9 commits into from
Jun 23, 2024

Conversation

JohnStarich
Copy link
Contributor

A couple changes to simplify various workflows, plus explicitly testing on the latest Go versions.

  • Enable race on all supported platforms, explicitly set -race= flag
  • Move linters-settings below linters list
  • Reformat octal integers to latest gofmt style
  • Fix comments to strictly follow godoc style
  • Disable govet's fieldalignment memory size check on test files
  • Test on Go 1.19-1.22, verify 32 bit field alignment on Linux with latest Go

@JohnStarich JohnStarich force-pushed the feature/simplify-32bit-ci branch 2 times, most recently from 8f483cc to 5cd2014 Compare June 23, 2024 20:57
…est Go

Use latest wasmbrowsertest for Go 1.20+ test coverage compatibility
@JohnStarich JohnStarich force-pushed the feature/simplify-32bit-ci branch from 4a5543e to 295ee5e Compare June 23, 2024 21:27
@JohnStarich
Copy link
Contributor Author

I've changed up how the architecture is passed in, since I hit issues with installing other test dependencies (wasmbrowsertest) when the GOHOSTARCH was not the native arch.

I reverified we're still catching the field alignment issues with 8ede24a:

--- FAIL: TestChmod (0.00s)
panic: unaligned 64-bit atomic operation [recovered]
	panic: unaligned 64-bit atomic operation

@JohnStarich JohnStarich merged commit b05f4b7 into main Jun 23, 2024
9 checks passed
@JohnStarich JohnStarich deleted the feature/simplify-32bit-ci branch June 23, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant